Added warning flags and fixed them :)

5 files changed, 9 insertions, 8 deletions

diff --git a/libgui/Makefile b/libgui/Makefile
index a29a393..6d2f087 100644
--- a/libgui/Makefile
+++ b/libgui/Makefile
@@ -8,7 +8,8 @@ CC = ccache ../cross/opt/bin/i686-elf-gcc
 LD = ccache ../cross/opt/bin/i686-elf-ld
 AR = ccache ../cross/opt/bin/i686-elf-ar
 
-CFLAGS = -Wall -Wextra -nostdlib -nostdinc -fno-builtin -mgeneral-regs-only -std=c99 -m32 -pedantic-errors -Iinc/ -I../libc/inc/ -fPIE -Duserspace -Ofast
+WARNINGS = -Wall -Wextra -pedantic-errors -Wshadow -Wpointer-arith -Wwrite-strings -Wredundant-decls -Wnested-externs -Wno-long-long
+CFLAGS = $(WARNINGS) -nostdlib -nostdinc -fno-builtin -mgeneral-regs-only -std=c99 -m32 -Iinc/ -I../libc/inc/ -fPIE -Duserspace -Ofast
 
 all: libgui
 
diff --git a/libgui/bmp.c b/libgui/bmp.c
index 0b08aeb..25745a7 100644
--- a/libgui/bmp.c
+++ b/libgui/bmp.c
@@ -6,7 +6,7 @@
 #include <print.h>
 #include <sys.h>
 
-struct bmp *bmp_load(char *path)
+struct bmp *bmp_load(const char *path)
 {
 	void *buf = read(path);
 	if (!buf)
diff --git a/libgui/gfx.c b/libgui/gfx.c
index 6e8b56a..304f935 100644
--- a/libgui/gfx.c
+++ b/libgui/gfx.c
@@ -28,7 +28,7 @@ static void load_font(enum font_type font_type)
 	if (fonts[font_type])
 		return;
 
-	char *path = NULL;
+	const char *path = NULL;
 
 	switch (font_type) {
 	case FONT_8:
@@ -111,7 +111,7 @@ void gfx_write(struct context *ctx, int x, int y, enum font_type font_type, u32
 	/* gfx_redraw(); */
 }
 
-void gfx_load_image(struct context *ctx, char *path, int x, int y)
+void gfx_load_image(struct context *ctx, const char *path, int x, int y)
 {
 	// TODO: Support x, y
 	struct bmp *bmp = bmp_load(path);
@@ -130,7 +130,7 @@ void gfx_load_image(struct context *ctx, char *path, int x, int y)
 	/* gfx_redraw(); */
 }
 
-void gfx_load_wallpaper(struct context *ctx, char *path)
+void gfx_load_wallpaper(struct context *ctx, const char *path)
 {
 	gfx_load_image(ctx, path, 0, 0);
 }
diff --git a/libgui/inc/bmp.h b/libgui/inc/bmp.h
index 909bc92..ea7a07f 100644
--- a/libgui/inc/bmp.h
+++ b/libgui/inc/bmp.h
@@ -34,6 +34,6 @@ struct bmp {
 	u32 pitch;
 };
 
-struct bmp *bmp_load(char *path);
+struct bmp *bmp_load(const char *path);
 
 #endif
diff --git a/libgui/inc/gfx.h b/libgui/inc/gfx.h
index 0b37d84..58a03cb 100644
--- a/libgui/inc/gfx.h
+++ b/libgui/inc/gfx.h
@@ -67,8 +67,8 @@ struct context {
 struct font *gfx_resolve_font(enum font_type font_type);
 void gfx_write_char(struct context *ctx, int x, int y, enum font_type font_type, u32 c, char ch);
 void gfx_write(struct context *ctx, int x, int y, enum font_type font_type, u32 c, char *text);
-void gfx_load_image(struct context *ctx, char *path, int x, int y);
-void gfx_load_wallpaper(struct context *ctx, char *path);
+void gfx_load_image(struct context *ctx, const char *path, int x, int y);
+void gfx_load_wallpaper(struct context *ctx, const char *path);
 void gfx_copy(struct context *dest, struct context *src, int x, int y, u32 width, u32 height);
 void gfx_ctx_on_ctx(struct context *dest, struct context *src, int x, int y);
 void gfx_draw_rectangle(struct context *ctx, int x1, int y1, int x2, int y2, u32 c);